-
Notifications
You must be signed in to change notification settings - Fork 395
add CF band to homepage and CF footer #2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CF band to homepage and CF footer #2356
Conversation
|
🙈 The PR is closed and the preview is expired. |
| - page: Wallpapers | ||
| url: /desktopwallpapers | ||
| - page: Privacy Policy | ||
| url: https://www.redhat.com/en/about/privacy-policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the Red Hat privacy policy still apply? Commonhaus has one for itself (but not necessarily for its projects): https://www.commonhaus.org/policies/privacy-policy/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The privacy policy is required since we're still using Adobe Analytics. This covers us for GDPR compliance.
|
@holly-cummins - We use a 12 column grid and that version it was a 7/5 split of logo to content. I've reversed it to 5/7 with my last commit. |
|
It looks great and I'm eager to merge it - would it be ok if I pressed the big green button? I do have some minor nitpicks but I think I'd prefer to let @insectengine to choose if he'd want to handle them as a follow up or not at all :) Here is my screenshot (just the bottom bit):
Two things stand out:
Both of these look totally fine on mobile though. I appreciate my display is large Neither seem blocking so I'd rather merge and polish later though. It's also still undecided if we should keep the "Sponsored by Red Hat" altogether so wouldn't want you to spend too many cycles on it, if it's not a trivial change. |
Actually let's just do it, @insectengine I'll leave it up to you to decide if my nitpicks are worthy of a follow up. Thanks a lot! |
|
Thanks @insectengine, @holly-cummins and @Sanne. The same should be used in the other CommonHaus project that moved at the same time as Quarkus (SmallRye, Qbic) |
|
Thanks I'll transition that to the Mutiny projects, and future releases will reflect that change. |
|
Good point, but bear in mind that there's the possibility that @insectengine will want to apply some more tweaks - perhaps give it some days for things to settle, so to avoid a multitude of patches. |
|
@Sanne - Think this issue will require a change of how this is built as columns based layout will force this space. We can limit the size of the CF logo, but that will just emphasize the spacing problem. I'll have to refactor this a bit #bigscreenproblems @jponge @radcortez @dmlloyd - hold off on this until I get this sorted. |




Contained in this commit: